Display public ip addresses for shared network by ravening · Pull Request #4676 · apache/cloudstack

ravening · 2021-02-10T12:17:38Z

Description

If a vm belongs to shared network then display the list
of ip addresses available which can be used to assign for
secondary IP addresses.

Also display "Public IP addresses" tab for shared networks

List all public ip address in shared network

Display the list of ip address while adding secondary ip instead of user input box

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache · 2021-02-12T12:30:43Z

@ravening does this rely on some code changes ?

ravening · 2021-02-12T12:33:05Z

@ravening does this rely on some code changes ?

@weizhouapache dont think so.. public ip address should be listed by default

weizhouapache · 2021-02-12T13:03:05Z

@ravening does this rely on some code changes ?

@weizhouapache dont think so.. public ip address should be listed by default

@ravening but listing ips in shared network does not work, right ?

ravening · 2021-02-16T11:45:00Z

@ravening does this rely on some code changes ?

@weizhouapache dont think so.. public ip address should be listed by default

@ravening but listing ips in shared network does not work, right ?

@weizhouapache I can display it

(local) mgt01 > list publicipaddresses listall=true fordisplay=true allocatedonly=false forvirtualnetwork=true filter=ipaddress,
{
  "count": 59,
  "publicipaddress": [

weizhouapache · 2021-02-16T13:09:19Z

@ravening does this rely on some code changes ?

@weizhouapache dont think so.. public ip address should be listed by default

@ravening but listing ips in shared network does not work, right ?

@weizhouapache I can display it
(local) mgt01 > list publicipaddresses listall=true fordisplay=true allocatedonly=false forvirtualnetwork=true filter=ipaddress,
{
  "count": 59,
  "publicipaddress": [

@ravening ok.
I tested with 4.15.1.0, it worked.

by the way, forvirtualnetwork should be 'false', and networkid should be passed.

yadvr · 2021-03-24T07:06:12Z

@ravening @weizhouapache does it make sense to change base to 4.15 to 4.15.1?

Pearl1594 · 2021-03-29T12:10:36Z

@ravening Could you please address the conflict. Thanks.

shwstppr · 2021-03-31T03:35:43Z

ping @ravening

If a vm belongs to shared network then display the list of ip addresses available which can be used to assign for secondary IP addresses. Also display "Public IP addresses" tab for shared networks

Pearl1594 · 2021-03-31T11:24:36Z

@blueorangutan ui

blueorangutan · 2021-03-31T11:25:03Z

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-03-31T11:29:11Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4676 (SL-JID-81)

Pearl1594 · 2021-03-31T12:56:09Z

ui/src/views/compute/InstanceTab.vue

+    onAcquireSecondaryIPAddress (record) {
+      if (record.nic.type === 'Shared') {
+        this.editNicResource = record.nic
+        this.editNetworkId = record.nic.networkid


@ravening I believe L466-467 need to be moved outside the if block as in a case where we have one nic on an Isolated network & one on a shared network; if you first attempt adding a secondary IP for the nic on a shared network and then do the same for the nic on Isolated network, it continues to show the shared n/ws public ips

yadvr · 2021-04-01T07:06:51Z

ping @ravening cc @weizhouapache - any progress/update on this?

@utchoang cc @svenvogel - can you help review/test this as well?

utchoang · 2021-04-01T07:35:31Z

@ravening
An error occurred while navigating to the IP address, network resource page

Public IP resource:
Network:

ravening · 2021-04-01T10:06:24Z

@ravening
An error occurred while navigating to the IP address, network resource page

Public IP resource:

Network:

@utchoang @Pearl1594 can you guys test/review the code again?

Pearl1594 · 2021-04-01T11:59:35Z

@blueorangutan ui

blueorangutan · 2021-04-01T12:00:02Z

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-04-01T12:04:10Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4676 (SL-JID-85)

utchoang

LGTM!

Pearl1594

Verified behavior. LGTM

shwstppr added this to the 4.16.0.0 milestone Feb 11, 2021

weizhouapache mentioned this pull request Mar 23, 2021

API command listPublicIpAddresses lists IPs only with forvirtualnetwork=true #4853

Closed

yadvr changed the base branch from master to 4.15 March 24, 2021 07:06

yadvr changed the base branch from 4.15 to master March 24, 2021 07:06

yadvr modified the milestones: 4.16.0.0, 4.15.1.0 Mar 24, 2021

yadvr assigned shwstppr Mar 24, 2021

shwstppr added the component:UI label Mar 25, 2021

yadvr requested review from Pearl1594, davidjumani and utchoang March 29, 2021 10:47

ravening force-pushed the shared-network-changes branch from 26fd877 to e383dd3 Compare March 31, 2021 11:02

Display public ip addresses for shared network

c990f73

If a vm belongs to shared network then display the list of ip addresses available which can be used to assign for secondary IP addresses. Also display "Public IP addresses" tab for shared networks

ravening force-pushed the shared-network-changes branch from e383dd3 to c990f73 Compare March 31, 2021 11:03

ravening changed the base branch from master to 4.15 March 31, 2021 11:03

Pearl1594 reviewed Mar 31, 2021

View reviewed changes

bug fix

a8ee004

utchoang approved these changes Apr 2, 2021

View reviewed changes

weizhouapache approved these changes Apr 2, 2021

View reviewed changes

yadvr requested a review from Pearl1594 April 4, 2021 07:35

Pearl1594 approved these changes Apr 5, 2021

View reviewed changes

yadvr merged commit c75c6ba into apache:4.15 Apr 5, 2021

Conversation

ravening commented Feb 10, 2021

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Feb 12, 2021

Uh oh!

ravening commented Feb 12, 2021

Uh oh!

weizhouapache commented Feb 12, 2021

Uh oh!

ravening commented Feb 16, 2021

Uh oh!

weizhouapache commented Feb 16, 2021

Uh oh!

yadvr commented Mar 24, 2021

Uh oh!

Pearl1594 commented Mar 29, 2021

Uh oh!

shwstppr commented Mar 31, 2021

Uh oh!

Pearl1594 commented Mar 31, 2021

Uh oh!

blueorangutan commented Mar 31, 2021

Uh oh!

blueorangutan commented Mar 31, 2021

Uh oh!

Pearl1594 Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

yadvr commented Apr 1, 2021

Uh oh!

utchoang commented Apr 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ravening commented Apr 1, 2021

Uh oh!

Pearl1594 commented Apr 1, 2021

Uh oh!

blueorangutan commented Apr 1, 2021

Uh oh!

blueorangutan commented Apr 1, 2021

Uh oh!

utchoang left a comment

Choose a reason for hiding this comment

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

utchoang commented Apr 1, 2021 •

edited

Loading